Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevEx]: components name instance in pascalcase #617

Merged
merged 5 commits into from
Oct 9, 2023
Merged

[DevEx]: components name instance in pascalcase #617

merged 5 commits into from
Oct 9, 2023

Conversation

haaarsh619
Copy link
Contributor

Issue number #396

Relevant issue number

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

seriouslysean
seriouslysean reviewed Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@seriouslysean seriouslysean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the files changed look in line with the designation to me, leaving finally approval to @itsalaidbacklife -- just one callout that isn't a blocker by any means.

src/components/GameView/CounterDialog.vue Show resolved Hide resolved
itsalaidbacklife
itsalaidbacklife reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@itsalaidbacklife itsalaidbacklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one question about the config in the comments

.eslintrc.js Outdated Show resolved Hide resolved
src/components/GameView/CannotCounterDialog.vue Outdated Show resolved Hide resolved
src/components/GameView/CounterDialog.vue Show resolved Hide resolved
@itsalaidbacklife itsalaidbacklife added the version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) label Oct 9, 2023
itsalaidbacklife
itsalaidbacklife approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@itsalaidbacklife itsalaidbacklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Good linting simplifies maintenance, which is especially valuable during hacktoberfest. Thank you!

@itsalaidbacklife itsalaidbacklife merged commit c586c06 into cuttle-cards:main Oct 9, 2023
@itsalaidbacklife itsalaidbacklife added hacktoberfest This issue welcomes contributions for Hacktoberfest. frontend Requires changes to the frontend (vue) client labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriouslysean seriouslysean seriouslysean left review comments

@itsalaidbacklife itsalaidbacklife itsalaidbacklife approved these changes

Assignees
No one assigned
Labels
frontend Requires changes to the frontend (vue) client hacktoberfest This issue welcomes contributions for Hacktoberfest. version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DevEx]: Update component <template> code to use PascalCase for custom component name instances
3 participants
@haaarsh619 @seriouslysean @itsalaidbacklife